Wrap "Pattern too complex" exception into an IllegalArgumentException #109173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afoucret
added
>bug
:Search Foundations/Mapping
|
Hi @afoucret, I've created a changelog YAML for you. |
|
Pinging @elastic/es-search (Team:Search) |
elasticsearchmachine
removed
the
Team:SearchOrg
| settings: | ||
| index: | ||
| analysis: | ||
| analyzer: |
There was a problem hiding this comment.
What is the rectangle shaped char at the end of each line? Can we remove them?
There was a problem hiding this comment.
GH does not render it well - but this is an actual case where we know Pattern::compile throws an OutOfMemoryError so I think it is fine to keep it. Might be worth adding a comment here for folks that might read this code in the future? @afoucret
There was a problem hiding this comment.
I moved this test to a more appropriate place and added a comment to it
kderusso
approved these changes
May 29, 2024
ioanatia
approved these changes
May 30, 2024
afoucret
added
auto-backport
💚 Backport successful
|
afoucret
added a commit
that referenced
this pull request
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of
java.util.regex.Pattern.:compilehas been updated in a way that make it possible too handle OutOfMemoryError errors cause by too complex pattern more gracefully and make them recoverable.